Daniel Xu

While it's true changing from async to sync is backwards compatible, I'm a little worried about large maps overflowing the perg/ring buffer. In theory the user could be relying on...

Tangentially related: rust and golang have a edition/version mechanisms for these kinds of subtle changes. Basically you tell the compiler which edition/version you want to build against, and compiler will...

(Sorry for stream of consciousness) Maybe we could add an `aprint()` alias for the old behavior? And `print()` gets sync by default. I imagine this is beneficial for nearly everyone...

> > I'm leaning toward @danobi's suggestion of adding an async print builtin. It's more explicit and removes the need for map copying. > > Why not the explicit map...

For the existing builtin functions that support optional parameters, should we also give them optional named parameters? Then for consistency, allow `async=` to be unnamed as well?

Related: https://github.com/bpftrace/bpftrace/issues/2772

Closing as dup. A little more context was added to other issue

Yeah that does sound rather useful. Looking at how we store `commit_id` ( https://github.com/danobi/prr/blob/6219a6cbe656fa34e9d288f7a5a622d977e6e85b/src/review.rs#L33-L34 ) may be a good place to start. As for getting the changes since last review,...

I think I've come around on this. For sensitive things like tokens, env var seems standard. Let's special case it. Using the prominent GH env vars makes sense to me....

Cool! I don't use vscode so I'm not sure how that ecosystem works. If there's anything I can do to help there just let me know. An LSP server would...