prr icon indicating copy to clipboard operation
prr copied to clipboard

Comments on large diffs are not accepted

Open drahnr opened this issue 3 years ago • 1 comments

> diff --git a/foo.json b/foo.json
> deleted file mode 100644
> index f132fcb..0000000
> --- a/foo.json
> +++ /dev/null
> @@ -1,150 +0,0 @@

Please don't delete this mingled with other changes in the same PR

> -{
> -  "name": "baz",
> -  "id": "bar",
> -  "properties": null,
// many more lines
Error: Error during POST: Status code: 422 Unprocessable Entity, Body: {"message":"Unprocessable Entity","errors":["Pull request review thread path diff too large and Pull request review thread diff hunk can't be blank"],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-review-for-a-pull-request"}

drahnr avatar Aug 19 '22 08:08 drahnr

When I try leaving a comment on the 0 line I get this error:

Error: Error during POST: Status code: 422 Unprocessable Entity, Body: {"message":"Unprocessable Entity","errors":["Pull request review thread line required and an integer greater than zero and Pull request review thread diff hunk can't be blank"],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-review-for-a-pull-request"}

which is different than your error.

Maybe GH has limitations on which files can be commented on? eg for too large of diffs? Not sure

danobi avatar Aug 19 '22 17:08 danobi