Daniel Xu comments

Results 427 comments of


                                            Daniel Xu

build master failed on rpi4

Hard to tell from just the error, but maybe the LLVM you're linking against did not build for all targets? Can you try the nix build instead? https://github.com/iovisor/bpftrace/blob/master/docs/nix.md

Quote strings when printing tuples

My feeling in this is we should print whatever is better visually for the user. Seems like there’s a lot of awkward cases to handle if we wanna be consistent....

ci: Add clang-tidy job

I'm thinking that rather than get fancy with the GH action, we should slowly allow-list lints into `.clang-tidy.yml` paired with codemods. That way, codebase always stays clang-tidy clean and we...

Improving the documentations

Thanks for you contributions @xh4n3 ! You're welcome back any time :)

Reserved keywords conflicting with user defined types

May be good inspiration: https://doc.rust-lang.org/rust-by-example/compatibility/raw_identifiers.html

Reserved keywords conflicting with user defined types

I think this issue is also strong motivation to avoid adding more keywords. A standard library using user defined function functionality would help.

Implement delete() with wildcards via for_each_elem

Another thought: would this feature overlap with https://github.com/iovisor/bpftrace/issues/2955 ? For example, if we can loop over the key/value pairs of a map, would it also be possible to `delete()` entries...

Implement delete() with wildcards via for_each_elem

Another dimension to consider: since user-defined functions are close to merging, would it make sense to start writing a standard library? With map loops and user-defined functions, we could in...

Implement delete() with wildcards via for_each_elem

codeql warning looks legit. Seems `is_quoted_type()` is missing map_wildcard

Implement delete() with wildcards via for_each_elem

Do we still need this now that looping over map elements is supported?