Daniel Xu
Daniel Xu
Yes, please feel free.
Followup: try to detect opportunities to use structured binding: https://en.cppreference.com/w/cpp/language/structured_binding see: https://github.com/bpftrace/bpftrace/pull/2988#discussion_r1492826821
Seems more like a lack of a feature to me
Looks like a legit unit test failure
Fixing this would technically be backwards incompatible. But surely nobody is relying on this buggy behavior, right?
Ah ok, easy enough bug to fix. Semantic analyser (and codegen_llvm but that's less important) simply does not respect lexical scope. We'd want to create some kind of stack data...
Man, I really licked this cookie. I'm gonna try to focus on all the half finished stuff I've got. So other folks should feel free to pick this up
I don't think python does hoisting. My understanding (which could be wrong) is that it just does dynamic lookups. Eg: ``` >>> for i in range(5): ... if i ==...
All variables being probe scoped is an interesting idea. I hadn't considered that nor thought to describe the current behavior that way.
While I think looking at other languages is useful to see what's been done and how it played out, I think we should be careful to start from first principles...