Danny McClain

Results 178 comments of Danny McClain

Just a quick note that the updated button doesn't need to be a fixed width. It can just can just follow the standard button padding. Reference here for medium buttons...

Is this in any way related to [this convo](https://expensify.slack.com/archives/C03U7DCU4/p1709661920842379) we recently had in Slack about disabled categories? Basically disabled categories (or tags) that are currently selected should look disabled, still...

> though I guess we'd still show the selected BG color on the row too right? Yeah I think we would.

> Looks good from a design standpoint. Dangit Shawn you beat me by ONE minute! 😂

> But I think my vote is to just close and do nothing. I'm cool with this—it seems kinda like a pretty weird edge case to me, and it looks...

@shawnborton I don't think we do... Looks like based on Figma comments we're still debating between a few options. Should I take it to Slack to try to get final...

Ok we've settled on a final design for this feature. cc @Expensify/design @shawnborton just making sure this all looks right to you! [Figma file is here.](https://www.figma.com/file/GuXL2bpQRauOa5qCD3ZesG/NewDot-Violations?type=design&node-id=1201-22154&mode=design&t=4B9KAINywE51TBuB-11) ![image](https://github.com/Expensify/App/assets/7516624/ea07b0c5-98d5-4a48-8ab2-978baabff5da)

@shawnborton I think it does look kinda silly haha. You can check [these out in Figma](https://www.figma.com/file/GuXL2bpQRauOa5qCD3ZesG/NewDot-Violations?type=design&node-id=1201-25121&mode=design&t=4B9KAINywE51TBuB-11): 20px icons (pretty silly), 16px icons (might be ok?), 12px icons (current design).

@Krishna2323 The screenshots in [your comment](https://github.com/Expensify/App/pull/37813#issuecomment-2014152396) look great to me.

The spacing updates feel good to me too. Just so I'm clear though—issues with the receipt will always show _above_ other violation messages right? I think it's important that receipt...