Danny McClain

Results 178 comments of Danny McClain

>curious what you think - on the desktop version, should we use the 32px padding for the text/icon/button area? I'm not _intensely_ passionate, but I'm for using 32px padding on...

I like it with 32px! At least for these wider "empty-state-style" ones. And I think the bottom padding is good 🙃

I think showing a fallback image makes sense—but I'm not sure I would show that type of thumbnail. I feel like it kinda makes more sense to show our little...

>We're going to prevent uploading corrupted PDF as scan receipt in https://github.com/Expensify/App/issues/34032. So to be consistent, we should not allow corrupted images. @situchan that makes sense to me. >For no-preview...

One thing I think we need to consider that [Krishna's proposal](https://github.com/Expensify/App/issues/51504#issuecomment-2445925882) made me realize: I think we should auto-update the avatar when the name field is blurred (or _something_ like...

Yeah I was thinking about that too. Seems unlikely they'll actually unfocus the input. Maybe we just update it as soon as the input has a new first character? 🤷

>disclaimer: I am not involved in evaluating proposals :) Haha same! But that is what I had in mind.

Also this is feeling verrrrrry tight to me: ![CleanShot 2024-09-19 at 08 23 23@2x](https://github.com/user-attachments/assets/40e52349-8b7a-4de4-8a39-39c9f34e5548) Can we try `20px` between the number inputs and the `Didn't receive a magic code?` message?...

For that case I think we'd do it like this: ![image](https://github.com/user-attachments/assets/03bd6a95-4c3d-4fca-a2cf-724f6292928f) But happy for Shawn to weigh in too!