Dan McDonald

Results 97 comments of Dan McDonald

Should we just make this PR OS-8682's official one?

> > Should we just make this PR OS-8682's official one? > > I just created a new branch to make it official #517. git pbchk is clean. Should this...

Also check `fmadm faulty` since it's ECC, you might see something there.

1.) The testing burden for an upgrade like this is high. We ship: - Tons of bash scripts - Tons of autocomplete scripts (no idea how backward-compatible bash versions are,...

Have you happened to try the adminui after this change? I’m curious if it sucks up the new brand name or not. I'm happy to try this if you wish.

We do not accept pull requests. Please visit here: https://illumos.org/docs/contributing/gerrit/ and submit this via Gerrit, and remind the community at the illumos developer's list: https://illumos.org/docs/community/lists/

> fyi [@nodejs/platform-smartos](https://github.com/orgs/nodejs/teams/platform-smartos) Our current Jenkins build zones we provide you do not have gcc13 in them. The ones I use to fix bugs, however: ``` nuc-build-2024(~)[0]% gcc --version gcc...

We also have clang in pkgsrc: ``` nuc-build-2024(~)[0]% pkgin avail | grep clang clang-18.1.8nb3 C language family frontend for LLVM opencl-clang-18.1.0nb3 OpenCL-oriented wrapper library around clang nuc-build-2024(~)[0]% ``` and I...

Also, this v8 fix isn't in node yet (never mind upstream V8), but needs to be if we wanna solve the gcc13 and/or clang problem: nodejs/node#58237

Is it important that illumos/SmartOS jump to clang 19, as opposed to using a gcc that does the right C++ thing? Moving to the most recent SmartOS-specific build environment (pkgsrc...