Dan McDonald

Results 97 comments of Dan McDonald

@jperkin With recent discoveries while creating a 24.4.1 regular build zone for smartos-ui, we probably need this up NOW rather than later.

> @danmcd the [illumos patch](https://github.com/nodejs/node/commit/838e2332a5feb3c4fa703fd22c64200acdc78463) doesn't apply anymore so I had to skip it, but SmartOS still fails to build: https://ci.nodejs.org/job/node-test-commit-smartos/60903/nodes=smartos23-x64/ Yeah... this is because of the AIX patch to...

@targos -> This commit is supposed to re-fix the VA48 in V8 post-IBM-fix: https://github.com/danmcd/node/commit/4370850da862e12f5cab13d4f5522305966e91af but I'm getting coredumps from `node_mksnapshot` like I did last time around and I'm wondering if...

Yeah my first post-IBM patch was broken badly. This one: https://github.com/danmcd/node/commit/4370850da862e12f5cab13d4f5522305966e91af has both compiled and shown only this for `gmake test`: ``` [07:16|% 100|+ 4430|- 1]: Done Failed tests: out/Release/node...

> > @nodejs/platform-aix PTAL at https://ci.nodejs.org/job/node-test-commit-aix/57505/nodes=aix72-ppc64/console > > ``` > > 18:58:48 ../deps/v8/src/objects/feedback-vector.cc: In member function 'void v8::internal::FeedbackVector::ClearOptimizedCode()': > > 18:58:48 ../deps/v8/src/objects/feedback-vector.cc:441:41: error: 'GetIsolate' was not declared in this scope;...

> @danmcd > > My suggestion above was to just turn off the switch that disables building with leaptiering (added back in 13.4). Now that the leaptiering changes are upstreamed...

> CI: https://ci.nodejs.org/job/node-test-pull-request/67403/ The illumos patch https://github.com/nodejs/node/pull/58491/commits/96b370f5049014f42752e064b44dafdfda24976f is not the correct one to apply after the IBM commit. (EDIT/AMEND): Uggh, let's try this again. See here: https://github.com/danmcd/node/commits/v8-138/ There's a revert-commit...

See TritonDataCenter/smartos-live#940 ...

Interesting. On Linux, do writing to those affect not-only TCP, but ALSO UDP, SCTP, and even AF_UNIX sockets? If so, we'll need to make a design decision. I'll need some...