illumos-extra icon indicating copy to clipboard operation
illumos-extra copied to clipboard

OS-8602 update bash to 5.2

Open tsoome opened this issue 1 year ago • 2 comments

I used the patches collected in openindiana oi-userland tree (just because I happen to have that repo clone). The disable-function-import.diff is from current bash (with small update because of context change). Also had to update diffs a bit to match our patch procedure (-p1).

tsoome avatar Nov 21 '24 15:11 tsoome

1.) The testing burden for an upgrade like this is high. We ship:

  • Tons of bash scripts
  • Tons of autocomplete scripts (no idea how backward-compatible bash versions are, esp jumping from 4.x to 5.x
  • shlibs for bash.

2.) The OmniOS build of bash has FAR FEWER patches, but it's very possible its fetch-patches script: https://github.com/omniosorg/omnios-build/blob/master/build/bash/patches/fetch-patches does that heavy lifting.

danmcd avatar Nov 21 '24 17:11 danmcd

1.) The testing burden for an upgrade like this is high. We ship:

  • Tons of bash scripts
  • Tons of autocomplete scripts (no idea how backward-compatible bash versions are, esp jumping from 4.x to 5.x
  • shlibs for bash.

ok, this sounds like for quick fix it is still better to poke that old horse and have more time for upgrade.

2.) The OmniOS build of bash has FAR FEWER patches, but it's very possible its fetch-patches script: https://github.com/omniosorg/omnios-build/blob/master/build/bash/patches/fetch-patches does that heavy lifting.

Yes, the thing there is that they seem to publish tarball and then minor issues fixed in form of patches.

tsoome avatar Nov 21 '24 17:11 tsoome