Daniel Marjamäki

Results 387 comments of Daniel Marjamäki

thanks I have added your name to AUTHORS with the commit f81fc1129bbd337697fe18e16d80b0ca5e1cc376

> And one more question, hand-made memset, shall we check it too? I am not against it.

For information.. I do feel a bit skeptic about the performance category. Cppcheck can't know what difference each suggestion will make. I believe that in general, readability is more important...

I am not 100% sure but probably it's expected behavior. does it cause a problem?

> But what about []() symbols, why it's not a eBracket? ah yes. It would make sense that square brackets and round brackets are eBracket. Can we try to change...

> Also I tried to change and got strange fails in tests: TestUnusedVar::isRecordTypeWithoutSideEffects|cleanFunction|localvar15,56 ok thanks. Well we can try to remember to look into that someday.

ci is not happy. can you run the tests locally without problems?

please fix the tests. feel free to reopen this PR.

hmm.. my idea was to keep command line interface somewhat simple. only basic options there.. so I believe clang-tidy can currently be executed if user configures it from the GUI.

it's ok to add some option to configure clang-tidy checks in the GUI. > (ie. let clang search for .clang-tidy files) if there are .clang-tidy files it sounds good to...