Daniel Marjamäki

Results 388 comments of Daniel Marjamäki

> So I suggest we drop at least the Visual Studio 2013 support which would allow us to completely drop the Appveyor builds. There are some holes in the GitHub...

> The OVERRIDE define can be replaced with just the override usage now we move to GCC 4.8. We have been doing this in the GUI code already. this is...

Sorry .. I suggested that you would move this to `CheckFunction` but now I think `CheckType` would be better.

I guess it's because TestType does not load the `std.cfg`. But it can also be because the code is not normally preprocessed in the testrunner. You can't use preprocessor commands...

the ci is not happy. does the unit tests run fine for you locally?

I close this PR now. but please feel free to review the tests and reopen the PR.

the review comments have been ignored so I close this PR

I have a bit of second thought about this approach. Using macros is not exactly recommended these days. The original code is not very unreadable imho just more verbose. I...

I agree with firewave. I am not sure if some heuristic can be added to determine if it really should be private. maybe running this with test-my-pr.py will point out...