Daniel Marjamäki

Results 388 comments of Daniel Marjamäki

For the python scripts I feel sympathy for your security concerns. I do want to allow that custom scripts are written that are put in the project folder. I do...

what is the use case. can't you just remove the previously specified build-dir.

I don't see how the flag will be used in the pytest files. can't we do something in the pytest instead? also I think the behavior should be the same...

Isn't this going too extreme? Putting every function in a separate file. There are many small files that are less than 100 lines of code.

I would still say it's pretty extreme to put each function in a separate file. We could end up with 1000's of files if you continue to refactor cppcheck. As...

> however, I think a larger problem is that cppcheck seems to not like FooPrivate * const d = d_func() whereas it seems ok with const FooPrivate *d = d_func()...

> I'm not sure where to look or where to set qGetPtrHelper . can I get a hint? hmm.. you already identified that it's from Q_DECLARE_PRIVATE if a simple configuration...

I am not 100% sure that providing the exact real replacement lists for various macros is always a great idea. Maybe sometimes it's preferable to simplify the code. If this...

nice speedups! I am curious.. do you have any theory why there is speedup it just looks like a refactoring to me?

> The Token::Match() calls were not matchcompiled because they lived in a header. See previous discussion here. ah yes! :+1: