danigb
danigb
Hi @micahscopes Sorry, I've removed `scale.detect` from the core to release the 1.0.0. I will release it as a module soon. I'll keep you informed.
By the way, If you have the **exact** chroma, you can use `Dictionary.scale.names` to get the names: ```js const Tonal = require('tonal'); Tonal.Dictionary.scale.names('101011010101') // => [ 'major', 'ionian' ] ```
No, it gives all the possible names (name and aliases). Most of the time, an array with one element is returned. `major` and `ionian` are considered aliases in tonal.
I don't understand what you mean with "return the modes in order". Which function are you talking about?
Hi Manuel, I think you're right. There's no Scale.detect because, as you said, I think scale detection is just a matter of find the chroma of the notes and get...
Yes, agree. This is not a good expected result. Scale names and detection needs a good rework (see #56) (by the way: https://medium.com/@michaelkaulkin/name-that-chord-the-confusing-world-of-the-cadential-6-4-df58dd6a86cc) Thanks for reporting!
Yes, I don't know why it's called [tonal-detector](https://www.npmjs.com/package/tonal-detector). I have to change the name or update the docs. Anyway, as this issue suggest, chord and scale detection are not working...
Hi, Thanks for the PR! and sorry for the delay. A couple of things that I'm missing: 1. It would be great to have a reference of where those names...
Hello @jabza Thanks a lot for the PR! (and sorry the delay 🙏 ). The PR is great, but I'm a little bit unsure about this functionality. Strictly speaking, I...
I won't merge just because I don't think it is correctly from music theory point of view. You can simplify notes before getting into the detector. Thanks