danigb

Results 119 comments of danigb

Hi @devboell, First of all, thanks a lot for your work! I think a react-fretboard could be very useful (for certain applications ;-) Said that I find two major issues:...

Wow! Your demo has a much better look right now! 👍 Very nice work! I would like to integrate this into tonal demo. I'll get in touch when I have...

Hi @iwiedenm, Glad you like it. The demo app uses AudioContext and it should be prefixed in iPhone (webkitAudioContext). It's a trivial change, but I don't know when I can...

Hi, I'm not thinking in maintain two version on the same code. For this I'm thinking in two options: 1) Split the code in two modules. Something like `audio-loader` for...

The problem is that `Chord.steps` changed signature: ```diff -Tonal.Range.numeric([-3, 3]).map(Tonal.Chord.steps(["C4", "aug"])); +Tonal.Range.numeric([-3, 3]).map(Tonal.Chord.steps("aug", "C4")); ``` I'm fixing the docs in #473

Hey, thanks for the kind words. I'm not sure if this is what are you looking for, but there's this `volumeToGain` option that accepts a function that receives a volume...

What you mean is not in the docs? Is this issue fixed?

Feel free to reopen if still an issue.

Well, I guess this is intended. The rationale is that chord symbols always uses a uppercase letter for the note name. So minor D is "Dm" or "Dm7". In theory...