tonal icon indicating copy to clipboard operation
tonal copied to clipboard

Confusing results from Detect.chord

Open Mdashdotdashn opened this issue 6 years ago • 4 comments

Calling chord detection returns the '64' form for major chords which I found confusing as I had no idea what it meant.

Detect.chord([ '1P', '3M', '5P' ])
=> detected C64,Em#5

Mdashdotdashn avatar Mar 11 '18 19:03 Mdashdotdashn

Yes, agree. This is not a good expected result. Scale names and detection needs a good rework (see #56)

(by the way: https://medium.com/@michaelkaulkin/name-that-chord-the-confusing-world-of-the-cadential-6-4-df58dd6a86cc)

Thanks for reporting!

danigb avatar Apr 21 '18 18:04 danigb

How do you install Detect please?

I've tried npm install tonal then

const _tonal = require('tonal');
tonal.Detect.chord(['A','C','Eb'];

but Detect isn't part of tonal.

Then I tried npm install tonal-detect, as documented here: https://danigb.github.io/tonal/api/module-Detect.html, but tonal-detect isn't in npm.

Help :(

RichardJECooke avatar Aug 21 '18 18:08 RichardJECooke

Yes, I don't know why it's called tonal-detector. I have to change the name or update the docs.

Anyway, as this issue suggest, chord and scale detection are not working very smoothly.

danigb avatar Aug 22 '18 17:08 danigb

How is one supposed to use code from the extensions in the browser? Excuse me if it's trivial, i'm very novice with JS. Specifically I'm trying to use Tonal.Detect.chord().

In index.html I use

and I can call this just fine: Tonal.Chord.notes("C", "M");

however this is unable to find the chord function : Tonal.Detect.chord(["C", "E", "G"]);

and I think it's because Detect isn't in the minified distribution. trying to use the import function seems to be an endless pit of issues but I don't think I'm supposed to be using that in the browser.

btkramer9 avatar Apr 04 '19 00:04 btkramer9