Dániel Varga

Results 2 issues of Dániel Varga

The line https://github.com/nishnik/poincare_embeddings/blob/master/poincare.py#L134 says to maximize the distance between u and v. Indeed this is in accordance with Equation (6) of the paper, but I don't think it is correct....

DetectorCascade.imageWidth/imgHeight/imgWidthStep initialization has to happen before DetectorCascade::init() calls, through writing into public members. Turning them into init() arguments would be cleaner software design IMHO. But what really made my missing...