poincare_embeddings
poincare_embeddings copied to clipboard
Isn't there a sign error in Equation (6)?
The line https://github.com/nishnik/poincare_embeddings/blob/master/poincare.py#L134 says to maximize the distance between u and v. Indeed this is in accordance with Equation (6) of the paper, but I don't think it is correct. We should minimize the distance between related nodes, shouldn't we? If my reading is correct, alternative implementations https://github.com/TatsuyaShirakawa/poincare-embedding/blob/master/include/poincare_embedding.hpp#L584 and https://github.com/RaRe-Technologies/gensim/blob/e8264bd693408a487735bfb9dd12e46bdd3e8973/gensim/models/poincare.py#L299 do in fact minimize that distance. Am I confused?