Daniel Shahaf

command word: Order of expansions is wrong

3

https://github.com/zsh-users/zsh-syntax-highlighting/blob/5e4b446dee770a811ffb6c19ee41f624895e56da/highlighters/main/main-highlighter.zsh#L275-L300 As [zshexpn(1)](http://zsh.sourceforge.net/Doc/Release/Expansion.html#Expansion) specifies, alias expansion precedes parameter expansion which precedes tilde expansion. However, the code implements them in a different order (e.g., tilde expansion is performed before alias expansion).

Highlight precommands and correct expansions order

10

This is i343-precommands-v2, but rebased, and with an extra commit about ${foo} parameter expansions. Related to #264, #328, #343, #168, #365 (see log messages and added comments).

After 0.8.0 is released, ask Sebastian to update the comparison screenshots on https://github.com/zdharma/fast-syntax-highlighting#features: several of the features missing there have been implemented.

Highlight parameter expansion history modifiers

7

`$foo:hey` should highlight `$foo:h` as a parameter expansion. - both within and without quotes - modifiers can be chained, `$foo:h:h:t`

Fixes #701. There's a TODO in the last commit.

Escaped variable-declaring reserved words are builtins

1

In `BUFFER='\local a=( /* )'`, the word `local` is highlighted as a reserved word where it's in fact a builtin.

"unknown-token" is overloaded

3

Highlighting all errors the same way makes sense from a UI perspective (*cough* #691 *cough*), but it makes the tests weaker: when a test checks that an alias is highlighted...

WIP: Highlight history modifiers (#485)

1

This is https://github.com/zsh-users/zsh-syntax-highlighting/issues/485#issuecomment-359181850, rebased and with the tests written (for reasons explained there). Concerns: - [ ] https://github.com/zsh-users/zsh-syntax-highlighting/issues/485#issuecomment-358833116 "Modifiers require braces when KSH_ARRAYS is set." - [ ] https://github.com/zsh-users/zsh-syntax-highlighting/issues/485#issuecomment-358833831 Modifiers...

Add a 256-color theme?

3

Shall we add a 256-color theme? We could enable it automatically after checking the terminal's capabilities in `${terminfo}`.

From zshexpn(1): > If the shell encounters the character sequence `tt(!")` > in the input, the history mechanism is temporarily disabled until > the current list (see > ifzman(zmanref(zshmisc))\ >...