Daniel Shahaf

Results 56 issues of Daniel Shahaf

In `: ${foo:?}`, the `?` is highlighted as `globbing`, even though it's not. Likewise in `: ${bar:*}`. Both of these are parameter expansion syntaxes that simply happen to involve characters...

Bug

- [x] https://openports.se/shells/zsh-syntax-highlighting - [x] http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/shells/zsh-syntax-highlighting/ - [x] Might as well link to https://repology.org/project/zsh-syntax-highlighting/versions so people can quickly check whether their distro's covered or not - [ ] Consider adding...

Task
component:docs
good first issue

Here's the implementation of ZSH_HIGHLIGHT_DIRS_BLACKLIST: https://github.com/zsh-users/zsh-syntax-highlighting/blob/e8517244f7d2ae4f9d979faf94608d6e4a74a73e/highlighters/main/main-highlighter.zsh#L1229-L1240 That runs a nested loop for each ordinary (non-option) word on the command line. I suspect that's not very performant. - [ ] Confirm...

Idea
performance

Supposing `ZSH_HIGHLIGHT_DIRS_BLACKLIST=( /foo )`, how should `: /foo/bar` be highlighted? Currently, it's highlighted as any ordinary (unquoted non-option) word is, even though it may denote a filename. Consider adding a...

Improvement
Idea

The `main` highlighter incorporates a zsh syntax parser. Separate that parser into an independently reusable component. The lexer is mostly handled by `bufferwords()` aka ${(z)}, ~~although subshells and command substitutions...

Idea

It's right there [at the top of the landing page](https://github.com/zsh-users/zsh-syntax-highlighting#zsh-syntax-highlighting-). The contrast of green and yellow foreground to the black background isn't too great.

Task
component:docs

Spun off from @m0vie's #759: - [ ] In the output of a failing test, where the actual and expected values are tabulated, add a marker on the left margin...

Improvement
Task
component:docs
component:tests

#535 / 3a7ddcd was a bug due to `_zsh_highlight_load_highlighters` running with the interactive environment's options. We already call `emulate -L` in `_zsh_highlight` for precisely this reason. Long-term we should switch...

Task

Fixes #631. WIP: test expectations should be updated (12 failures including cthulhu)

Task

In INSTALL.md, shall we change `source ./zsh-syntax-highlighting/zsh-syntax-highlighting.zsh` to `emulate zsh -c "source ./zsh-syntax-highlighting/zsh-syntax-highlighting.zsh"`? Compare the documentation of `autoload`: https://github.com/zsh-users/zsh/blob/fd627a504fd2a84833b7edcf92dd1595fcf11df9/Doc/Zsh/builtins.yo#L217-L224 In particular, I think this might have negated #622.

Improvement
Question
Task