Daniel Price
Daniel Price
some issues with this already fixed, the idea is to take a late-time snapshot from a calculation and run the dust nucleation part (Siess et al. 2022) on continuation of...
we need some documentation, ideally auto-generated from src/main/eos.F90, that documents what each equation of state option does (ieos=1,2,3,....) The idea would be similar to the script docs/scripts/sink_particle_properties.pl which creates sinks.rst,...
make SETUP=tde moddump SYSTEM=ifort on Mac OS fails with: ``` ifort -O3 -inline-factor=500 -mcmodel=medium -shared-intel -warn uninitialized -warn unused -warn truncated_source -no-wrap-margin -fPIC -qopenmp -r8 -o ../bin/phantommoddump prompting.o set_Bfield.o density_profiles.o...
Type of PR: new physics Description: - Added external force for orbits around an oblate central object with J2 moment (https://en.wikipedia.org/wiki/Geopotential_model) - Sink particles can now carry J2 moment indicating...
this is posted here as a reference, currently the supported solution for this is to use libphantom to call the read_dump routine directly, or to convert to another format (e.g....
both Passy and growth benchmarks are failing because the results differ slightly from reference solution: https://github.com/phantomSPH/phantom-benchmarks/issues/1 https://github.com/phantomSPH/phantom-benchmarks/issues/2 needs to be understood why this occurred. Errors are small (10^-8), but should...
Aim is to get compile time warnings down to zero on the master branch, then strictly enforce no-new-warnings on pull requests to keep the number of compile time warnings to...
the store_temperature option is now redundant (temperature is always stored) and can be removed from the code. Since the equation of state also now returns the temperature for all choices...
the changes on this are an improvement, so thanks for the efforts. I will merge to avoid the broken phantom2hdf5 but there are still a number of issues here: 1....
#ifdefs look horrible in the code, and make testing all possible compile-time combinations very difficult. We should avoid introducing any new #ifdefs, preferencing use of the logical flags from the...