Daniel Price

Results 29 comments of Daniel Price

confirmed, I think Gammie cooling was originally icooling=1 but is now icooling=3, so the disc setup should reflect this

passy failure caused by ced2b62c, can be compared to results from previous commit 790065be which passed

@dmentipl suggested a while ago to implement particle subtypes when we were thinking about multigrain dust with different dust sub-types. The reason subtypes got difficult was that the structure of...

For the record, I think the additional array is a good idea for the splitting/merging

the bigger issue with this utility, as per #70 is that format conversion should really not be done via the phantom read/write dump utilities, since: 1) the read_dump reads only...

I can reproduce this, but only in gfortran v10.2.0, not clear it is a problem in phantom. Could be related to this: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94672

I will try to run the full nightly build on this, so then we should be able to merge automatically

this is mainly a bug fix - we spent about 3 weeks trying to find the bug with the outer boundary, it was definitely not correct as written. The "sphereinbox"...

but the test failure here was as you predicted @jameswurster from Sedov test going wrong with the recent merge of the du/dt timestep condition to try to prevent the u...

to be clear, we just corrected a bug here, we did not change the boundary condition. Actually there are two lines here: i) the cs line, we fixed a bug...