Daniel Hoherd

Results 124 comments of Daniel Hoherd

Merged to master and cherry-picked to release-0.30. This will go out with 0.30.1 within the next week or so.

I've opened an internal issue to track this request: https://github.com/astronomer/issues/issues/4442

I think a good way to move forward on this is to write a functional test for the success condition and work towards making it pass.

@rob-1126 the title to this issue does not cover all of the changes that are included.

@paulczar here's a write-up I did on how to develop tests https://github.com/astronomer/airflow-chart/blob/31634a60610/tests/README.md

> Thanks, I'll circle back to this in a couple of days when I have a few minutes. @paulczar FYI there is a nuance to your situation that makes it...

@paulczar regarding tests, since Andrii initially asked for tests, we have migrated this repo to a pytest based chart testing framework that should be a lot easier and a lot...

@rob-1126 If your branch could re-use anything in this branch, that would be cool so @paulczar could get some clout for participating in this feature and be included in the...

I was able to reproduce this on v0.25.8 ``` $ alias nl='nl -s " " -nrz -w2 -ba' $ helm version version.BuildInfo{Version:"v3.8.1", GitCommit:"5cb9af4b1b271d11d7a97a71df3ac337dd94ad37", GitTreeState:"clean", GoVersion:"go1.17.5"} $ git remote -v origin...

PR is here: https://github.com/astronomer/airflow-chart/pull/304