Daniel Civit

Results 26 comments of Daniel Civit

Would it be possible to receive feedback for this PR and, ideally, an estimated time of when we could hope to have these payment method icons added or updated?

Hi @Lydia-shan-git. Thanks for your review. We already passed the icon through SVGO following your guidelines: https://github.com/activemerchant/payment_icons/blob/master/CONTRIBUTING.md ``` svgo app/assets/images/payment_icons/multisafepay.svg --disable={removeUnknownsAndDefaults,removeTitle,cleanupIDs,removeViewBox} multisafepay.svg: Done in 10 ms! 2.555 KiB - 0%...

Hi @Lydia-shan-git Thank you for checking and approving this pull request. We are concerned that even after approval, this pull request is still tagged as " Changes Requested", and that...

> Hi @danielcivit , are you able to resolve the folllowing conflict? > > git checkout -b MultiSafepay-multisafepay master git pull https://github.com/MultiSafepay/payment_icons.git multisafepay Step 2: Merge the changes and update...

Hi @dannye0231 - Thanks for pointing out the issue on the .yml file. - It's not fixed and merge conflict is solved.

> Hi @danielcivit , we'll need a re-base for this PR as well. It's done @dannye0231

Hi @dannye0231 Again, thanks for looking at this and your support. Merge conflict is solved now.

> Hi @danielcivit , are you able to re-base? Hello @dannye0231. It's done.

Would it be possible to receive feedback for this PR and, ideally, an estimated time of when we could hope to have these payment method icons added or updated?

Hi. Would it be possible to receive feedback for this PR and, ideally, an estimated time of when we could hope to have these payment method icons added or updated?