payment_icons icon indicating copy to clipboard operation
payment_icons copied to clipboard

Add MultiSafepay icon

Open danielcivit opened this issue 1 year ago • 1 comments

Why are you adding this icons?

MultiSafepay payment icon is missing. MultiSafepay has pioneered Europe's most personalized payments ecosystem for small to medium-sized businesses and marketplaces. More than 18,000 businesses have simplified their market expansion and freed up time to focus on innovation with MultiSafepay's end-to-end payments toolkit.

I'm adding/updating this icon(s) because ..

Help us identify yourself

  • [X] I'm working/collaborating with the brand directly and they have provided the icons.
  • [ ] I'm associated with the brand and I've read all the brand icon’s guidelines.
  • [ ] I'm an individual and I've read all the brand icon’s guidelines.

Link to the brand guidelines:

  • https://www.multisafepay.com/fileadmin/user_upload/downloads/MultiSafepay_Brand_Guidelines-2022_compressed.pdf
  • https://www.multisafepay.com/resources/media-kit
  • https://github.com/MultiSafepay/MultiSafepay-logos

Checklist to add new icons

  • [X] All icons have a corresponding entry in db/payment_icons.yml
  • [X] I have followed the icon guidelines detailed in the CONTRIBUTING.md file
  • [X] I have optimized the icon with SVGO
  • [X] I am confident that all icons are clear and easy to read/understand
  • [X] I have provided a link to the brand icon’s brand guidelines whenever possible.
  • [X] I have attached a screenshot comparison with the example icon provided in guidelines
  • [X] I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger.

If this pull request is not adding new icons, you can remove this checklist.

Attach a screenshot of the icon along side the example Visa icon

comparison

Tips how to create a screenshot

We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.

<!-- Change background color if needed to showcase your icon better -->
<style> body { background: black; } </style>

<!-- DO NOT DELETE EXAMPLE -->
<svg viewBox="0 0 38 24" xmlns="http://www.w3.org/2000/svg" role="img" width="38" height="24" aria-labelledby="pi-visa"><title id="pi-visa">Visa</title><path opacity=".07" d="M35 0H3C1.3 0 0 1.3 0 3v18c0 1.7 1.4 3 3 3h32c1.7 0 3-1.3 3-3V3c0-1.7-1.4-3-3-3z"/><path fill="#fff" d="M35 1c1.1 0 2 .9 2 2v18c0 1.1-.9 2-2 2H3c-1.1 0-2-.9-2-2V3c0-1.1.9-2 2-2h32"/><path d="M28.3 10.1H28c-.4 1-.7 1.5-1 3h1.9c-.3-1.5-.3-2.2-.6-3zm2.9 5.9h-1.7c-.1 0-.1 0-.2-.1l-.2-.9-.1-.2h-2.4c-.1 0-.2 0-.2.2l-.3.9c0 .1-.1.1-.1.1h-2.1l.2-.5L27 8.7c0-.5.3-.7.8-.7h1.5c.1 0 .2 0 .2.2l1.4 6.5c.1.4.2.7.2 1.1.1.1.1.1.1.2zm-13.4-.3l.4-1.8c.1 0 .2.1.2.1.7.3 1.4.5 2.1.4.2 0 .5-.1.7-.2.5-.2.5-.7.1-1.1-.2-.2-.5-.3-.8-.5-.4-.2-.8-.4-1.1-.7-1.2-1-.8-2.4-.1-3.1.6-.4.9-.8 1.7-.8 1.2 0 2.5 0 3.1.2h.1c-.1.6-.2 1.1-.4 1.7-.5-.2-1-.4-1.5-.4-.3 0-.6 0-.9.1-.2 0-.3.1-.4.2-.2.2-.2.5 0 .7l.5.4c.4.2.8.4 1.1.6.5.3 1 .8 1.1 1.4.2.9-.1 1.7-.9 2.3-.5.4-.7.6-1.4.6-1.4 0-2.5.1-3.4-.2-.1.2-.1.2-.2.1zm-3.5.3c.1-.7.1-.7.2-1 .5-2.2 1-4.5 1.4-6.7.1-.2.1-.3.3-.3H18c-.2 1.2-.4 2.1-.7 3.2-.3 1.5-.6 3-1 4.5 0 .2-.1.2-.3.2M5 8.2c0-.1.2-.2.3-.2h3.4c.5 0 .9.3 1 .8l.9 4.4c0 .1 0 .1.1.2 0-.1.1-.1.1-.1l2.1-5.1c-.1-.1 0-.2.1-.2h2.1c0 .1 0 .1-.1.2l-3.1 7.3c-.1.2-.1.3-.2.4-.1.1-.3 0-.5 0H9.7c-.1 0-.2 0-.2-.2L7.9 9.5c-.2-.2-.5-.5-.9-.6-.6-.3-1.7-.5-1.9-.5L5 8.2z" fill="#142688"/></svg>

<!-- TODO: insert your icon here -->
<svg role="img" viewBox="0 0 38 24" width="38" height="24" aria-labelledby="pi-multisafepay" xmlns="http://www.w3.org/2000/svg"><title id="pi-multisafepay">MultiSafepay</title><path opacity=".07" d="M35 0H3C1.3 0 0 1.3 0 3v18c0 1.7 1.4 3 3 3h32c1.7 0 3-1.3 3-3V3c0-1.7-1.4-3-3-3z"/><path fill="#fff" d="M35 1c1.1 0 2 .9 2 2v18c0 1.1-.9 2-2 2H3c-1.1 0-2-.9-2-2V3c0-1.1.9-2 2-2h32"/><path fill="#00abee" d="M7.68 10h.912l.878 2.168.857-2.168h.901v3.12h-.758v-1.872l-.703 1.872h-.615l-.692-1.883v1.883h-.78zm6.393 3.12h-.758v-.34a.917.917 0 01-.747.362c-.571 0-.967-.394-.967-1.062v-1.445h.758v1.357c0 .34.187.526.473.526.296 0 .483-.186.483-.526v-1.357h.758v2.485zm.374-3.284h.758v3.284h-.758zm1.252 1.424h-.308v-.625h.308V10h.758v.635h.494v.624h-.483v1.007c0 .142.066.208.23.208h.275v.646h-.384c-.517 0-.88-.219-.88-.865v-.995zm1.45-1.282c0-.23.186-.416.45-.416s.45.186.45.416c0 .23-.186.405-.45.405-.275 0-.45-.186-.45-.405zm.066.657h.758v2.485h-.758z"/><path fill="#004a71" d="M19.5 13.153c-.67 0-1.209-.329-1.23-.974h.812c.022.24.176.35.384.35.22 0 .363-.11.363-.296 0-.58-1.57-.262-1.56-1.379 0-.591.483-.93 1.154-.93.68 0 1.153.339 1.175.941h-.824c-.01-.197-.154-.317-.362-.328-.187 0-.319.087-.319.284 0 .537 1.549.296 1.549 1.347 0 .547-.418.985-1.143.985zm2.383-2.551c.374 0 .626.165.77.383v-.35h.757v2.485h-.758v-.35c-.143.219-.395.383-.769.383-.604 0-1.098-.493-1.098-1.292-.011-.766.483-1.259 1.098-1.259zm.22.657c-.286 0-.538.208-.538.602s.252.613.538.613.538-.219.538-.613c0-.383-.253-.602-.538-.602zm1.757.001h-.274v-.625h.274v-.066c0-.645.396-.974 1.165-.94v.656c-.297-.022-.396.066-.396.328v.022h.407v.624h-.407v1.861h-.758v-1.86zm2.46 1.893c-.724 0-1.262-.493-1.262-1.28 0-.789.516-1.282 1.263-1.282.725 0 1.241.482 1.241 1.237a1.53 1.53 0 01-.01.22h-1.736c.022.328.23.47.472.47a.416.416 0 00.395-.24h.813c-.099.503-.538.875-1.175.875zm-.493-1.51h.966c0-.274-.208-.428-.461-.428-.264 0-.461.143-.505.427zm3.503-1.041c.605 0 1.11.493 1.11 1.281 0 .777-.483 1.292-1.11 1.292a.913.913 0 01-.768-.383v1.528h-.758v-3.685h.758v.35c.143-.218.406-.383.769-.383zm-.23.657c-.286 0-.538.22-.538.613s.252.613.538.613.55-.219.55-.613-.264-.613-.55-.613zm2.581-.657c.374 0 .627.165.77.383v-.35h.757v2.485h-.758v-.35c-.142.219-.395.383-.769.383-.604 0-1.098-.493-1.098-1.292.01-.766.494-1.259 1.098-1.259zm.242.657c-.286 0-.538.208-.538.602s.252.613.538.613c.286 0 .538-.219.538-.613 0-.383-.252-.602-.538-.602zm3.493-.624h.824l-1.567 3.647h-.813l.568-1.239-1.028-2.408h.846l.577 1.565z"/><path fill="#00abee" d="M6.32 12.353L1.6 8.4v4.72h4.72z"/><path fill="#004a71" d="M6.32 8.4l-2.188 1.831 2.188 1.831z"/></svg>

If the icons are intended for use by Shopify, please provide the following info:

Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)

What's the expected date of this change to deploy on Shopify?

danielcivit avatar Oct 11 '24 10:10 danielcivit

Would it be possible to receive feedback for this PR and, ideally, an estimated time of when we could hope to have these payment method icons added or updated?

danielcivit avatar Oct 28 '24 09:10 danielcivit

Hi @Lydia-shan-git.

Thanks for your review. We already passed the icon through SVGO following your guidelines: https://github.com/activemerchant/payment_icons/blob/master/CONTRIBUTING.md

svgo app/assets/images/payment_icons/multisafepay.svg --disable={removeUnknownsAndDefaults,removeTitle,cleanupIDs,removeViewBox}

multisafepay.svg:
Done in 10 ms!
2.555 KiB - 0% = 2.555 KiB

As you can see, with that ruleset, there is no change in the size of the file.

danielcivit avatar Nov 05 '24 07:11 danielcivit

Hi @Lydia-shan-git

Thank you for checking and approving this pull request.

We are concerned that even after approval, this pull request is still tagged as " Changes Requested", and that due to this it may go unnoticed in the next release, thus delaying taking advantage of these changes.

  • Could you please let us know if this change will be included?
  • Could you please consider fixing the tagging to avoid confusion?
  • Could you please let us know when you plan to do the next release?

danielcivit avatar Nov 15 '24 07:11 danielcivit

Hi @danielcivit , are you able to resolve the folllowing conflict?

git checkout -b MultiSafepay-multisafepay master git pull https://github.com/MultiSafepay/payment_icons.git multisafepay Step 2: Merge the changes and update on GitHub.

git checkout master git merge --no-ff MultiSafepay-multisafepay git push origin master

dannye0231 avatar Dec 04 '24 18:12 dannye0231

Hi @danielcivit , are you able to resolve the folllowing conflict?

git checkout -b MultiSafepay-multisafepay master git pull https://github.com/MultiSafepay/payment_icons.git multisafepay Step 2: Merge the changes and update on GitHub.

git checkout master git merge --no-ff MultiSafepay-multisafepay git push origin master

Hello @dannye0231

Merge conflict is solved now. However tests are failing, but I don't see how it could be related to this PR. Could you let me know if something is pending to do on our side?

danielcivit avatar Dec 05 '24 09:12 danielcivit

Hi @danielcivit , are you able to fix the spacing at the beginning of your entries in the YML file? It should match how the other entries are spaced.

dannye0231 avatar Dec 05 '24 17:12 dannye0231

Hi @dannye0231

  • Thanks for pointing out the issue on the .yml file.
  • It's not fixed and merge conflict is solved.

danielcivit avatar Dec 11 '24 08:12 danielcivit

Hi @danielcivit , we'll need a re-base for this PR as well.

dannye0231 avatar Jan 08 '25 16:01 dannye0231

Hi @danielcivit , we'll need a re-base for this PR as well.

It's done @dannye0231

danielcivit avatar Jan 08 '25 16:01 danielcivit

Hi @danielcivit , can you merge this one again? Its now causing a conflict after I merged your first PR

dannye0231 avatar Jan 08 '25 18:01 dannye0231

Hi @danielcivit , any chance you can get this re-based soon? We will be starting the monthly merge process shortly.

dannye0231 avatar Jan 08 '25 19:01 dannye0231

Hi @dannye0231

Again, thanks for looking at this and your support. Merge conflict is solved now.

danielcivit avatar Jan 09 '25 07:01 danielcivit

Hi @danielcivit , are you able to re-base?

dannye0231 avatar Jan 27 '25 21:01 dannye0231

Hi @danielcivit , are you able to re-base?

Hello @dannye0231.

It's done.

danielcivit avatar Jan 28 '25 07:01 danielcivit