Daniel Civit

Results 26 comments of Daniel Civit

I have which is probably a related error and is clearly a problem with that dependency. I can see the following output within the container activity. ``` expose_1 | Laminas\Http\Header\Exception\RuntimeException...

The following is a PrestaShop core GitHub issue related: https://github.com/PrestaShop/PrestaShop/issues/18307

Would it be possible to receive feedback for this PR and, ideally, an estimated time of when we could hope to have these payment method icons added or updated?

Hi @Lydia-shan-git. Thanks for your review. We already passed the icon through SVGO following your guidelines: https://github.com/activemerchant/payment_icons/blob/master/CONTRIBUTING.md ``` svgo app/assets/images/payment_icons/payafterdeliveryinstalments.svg --disable={removeUnknownsAndDefaults,removeTitle,cleanupIDs,removeViewBox} payafterdeliveryinstalments.svg: Done in 11 ms! 2.671 KiB - 0%...

Hi @Lydia-shan-git Thank you for checking and approving this pull request. We are concerned that even after approval, this pull request is still tagged as " Changes Requested", and that...

Hi @Lydia-shan-git Thank you for checking and approving this pull request. We are concerned that even after approval, this pull request is still tagged as " Changes Requested", and that...

> Hi @danielcivit , are you able to resolve the following conflict? > > git checkout -b MultiSafepay-multisafepay-pay-after-delivery-installments master git pull https://github.com/MultiSafepay/payment_icons.git multisafepay-pay-after-delivery-installments Step 2: Merge the changes and update...

> Hi @danielcivit , looks like a spacing issue with your YML entry. I tried to fix it but I am unable to make the change as the branch isn't...

> Hi @danielcivit , are you able to re-base and push again? We ran into an issue and require that you re-base before we can merge. TY! It's done @dannye0231.

Would it be possible to receive feedback for this PR and, ideally, an estimated time of when we could hope to have these payment method icons added or updated?