Daniela Brozzoni
Daniela Brozzoni
I think this is ready to be worked on. It's a small change on the signer side which gives some pros (Bitcoin Core txs indistinguishable from the bdk ones, and...
> In terms of changing up the TxBuilder, I think this should be done in a separate PR, and would need more discussion. Ok, then I guess we'll just grind...
Concept ACK! Transactions with below-dust ouputs are non-standard, but still valid, so I think BDK should be able to create them. It could also be useful in some very rare...
The code looks good to me, can you please squash all the commits into the first one?
Mh... There are still two commits, and the latest one's message is a bit weird. I'd use interactive git rebases to fix (https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History) - I would reword the first commit...
@rajarshimaitra do you have in mind any other additional test? There's already a `test_allow_dust_limit`, I can't think of any other that could be useful
Oh no, I just noticed... @terror can you sign your commit? Otherwise I can't merge. If you prefer, I can sign it with my key.
tACK bfd7b2f65debe57edc5d563c071f0bfce592a8d2
I'm unassigning @Yureien as he hasn't updated #556 in a long while. If someone else wants to take a shot at this, it's all yours! You should probably use #556's...
I've just published hwi 0.2.1 btw :)