bdk
bdk copied to clipboard
bitcoindevkit
Add allow_dust method to TxBuilder
We needed this for testing our wallet with dust, does this look like a reasonable feature? If so, I'll go ahead and add a test, update the changelog, etc.
Concept ACK! Transactions with below-dust ouputs are non-standard, but still valid, so I think BDK should be able to create them. It could also be useful in some very rare cases, like for creating a notification output to an address.
The code looks good to me, can you please squash all the commits into the first one?
Mh... There are still two commits, and the latest one's message is a bit weird. I'd use interactive git rebases to fix (https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History) - I would reword the first commit to change the message, and drop entirely the second commit
Mh... There are still two commits, and the latest one's message is a bit weird. I'd use interactive git rebases to fix (https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History) - I would reword the first commit to change the message, and drop entirely the second commit
@danielabrozzoni Should be good to go now. PTAL
@rajarshimaitra do you have in mind any other additional test? There's already a test_allow_dust_limit, I can't think of any other that could be useful
Oh no, I just noticed... @terror can you sign your commit? Otherwise I can't merge. If you prefer, I can sign it with my key.