Daniela Brozzoni
Daniela Brozzoni
Where we would use this backend, btw? In `src/testutils/blockchain_tests.rs`, I suppose? > TL;DR Maybe we should implement a dummy RPC server instead of a dummy bdk::blockchain::Blockchain? Eh, to me it...
Concept ACK for this, at this point we all hate `CHANGELOG.md` 😄 Shouldn't we add a "## Changelog" subtitle in the PR template? Not all PRs make it into the...
I think the problem is: 1. We release bdk `0.21` 2. We merge fantastic things on master 3. Someone wants to patch bdk `0.21` with our master, to have the...
I merged another PR before this one, and now the CHANGELOG is conflicting :/ Sorry!
> Should we avoid using heap memory, and keep everything on the stack? Apparently, heap memory is more prone to exploints. Reference: [github.com/shellphish/how2heap](https://github.com/shellphish/how2heap) We could look into that, but it's...
Picking this up :)
> What do you think about the idea about being able to apply this logic before coin selection time so we know the weight of the forthcoming witness. That would...
Tests are failing, can you please update the PR? :) https://github.com/bitcoindevkit/bdk/pull/515 introduced the `is_spent` field in `LocalUtxo`, since you're testing coin selection (which uses only unspent utxos) you probably want...
I'll look into the code ASAP, sorry for the waiting :)
Once it compiles, I think it's ready 😄