D. Benesch

> Finally found time to give this a look, and I must say it's awesome 😍 🎉 > I renamed a bunch of stuff (I tend to over-rename things in...

Also, I'm wondering if we should save the text + references in a separate file like .json, .rst, .csv, .bib etc. rather than hard coding them? E.g. https://github.com/danibene/cite-neurokit2-hrv/blob/main/neurokit2_hrv_feat_info.csv Then it...

> The problem of having non .py files in the packages it's that then we need to ship additional files etc. and it complicates a bit the distribution. It's feasible,...

@VisLab Thank you for your help, it was an issue with the path & the example code runs now. Would you agree with redefining `windowSize` based on `1.0/detrendFreq` as suggested...

@VisLab Thank you for your response. To confirm I understood: 1. when `detrendType = 'linear'`, `detrendCutoff = 1` will filter with a cutoff frequency of 0.6667 Hz? 2. when `detrendType...

I've been working on adapting the HRV feature functions for bad periods of data: - To access the timestamps of the interbeat intervals, I modified the HRV functions to accept...

@DominiqueMakowski The changes I made in my branch allow for input with missing RRIs: https://github.com/danibene/NeuroKit/tree/feature/adjust_for_missing_intervals The issue is that I am unsure if I dealt with missing data in the...

> Isn't a median/mean NA imputation a good-enough approach for nonlinear? @DominiqueMakowski I don't think this could be applied as a blanket rule to all the nonlinear features, e.g. for...

> For hrv_time and hrv_frequency if the changes are safe I think we can have them in by default (we don't need an argument to "turn them off" - if...

Maybe this implementation could be a starting point: https://github.com/qiriro/PPG/blob/master/ppg/feature.py