D. Benesch
D. Benesch
Regarding the failing checks (sorry, didn't notice until I checked my email): For [README_examples](https://github.com/neuropsychology/NeuroKit/pull/680/checks#step:5:21): I have changed the line causing the error, `interpolated[int(x_values[-1]) :] = interpolated[int(x_values[-1])]`, in https://github.com/neuropsychology/NeuroKit/pull/666 - maybe...
@DominiqueMakowski > I'm half-convinced ab out the 4 Hz by default, it just seems really low to get frequency decomposition :/ How about a default of 7 or 10 Hz?...
@DominiqueMakowski > (I'm sorry for blocking here but I wanna make sure we make the best decisions for our defaults ^^) No worries, I appreciate the due diligence :) >...
@DominiqueMakowski sorry for not fixing that bug earlier, I think it's good now!
> Minor style issue https://github.com/neuropsychology/NeuroKit/runs/7420854905?check_suite_focus=true#step:8:23 to fix before we can merge! @DominiqueMakowski if I understood correctly it's an issue with signal_detrend()? Should I modify that file?
@DominiqueMakowski nice, thanks :)
Now that RRI can be a direct input to the HRV functions (https://github.com/neuropsychology/NeuroKit/pull/710), I'm closing this issue
@DominiqueMakowski @JanCBrammer I think it's good for review, but let me know if I'm missing anything!
@DominiqueMakowski > I'm not sure what to do here, I don't have a clear idea of the risks / benefits balance, and @JanCBrammer comment makes me cautious. Is it indeed...
@DominiqueMakowski > So if I understand, we want to add the possibility of interpolating arrays with nan pandas-style to bypass the usage of pandas and allow more control over it?...