Dan Harrin comments

Results 529 comments of


                                            Dan Harrin

Feature: Move affixes

Hi, I am closing this as I think it is quite far away from what Zep was looking for in the original issue

Add aria label to action th

There could be many actions, especially if they are grouped, so I don't think listing them is what we should do here. Also, this current PR is only suitable for...

Add aria label to action th

Sure, but it doesn't just need to adapt to the plural it also needs to be translated

Add aria label to action th

Thanks

Text column and entry tooltip per item

Yeah I think we probably could but it could be a breaking change if someone is calling that method. I might push this back to v4

Text column and entry tooltip per item

I'll leave this open as a reminder to work on it myself, thanks

Text column and entry tooltip per item

Replaced by #14967 for v4

fillForm() appears to be broken since it can accept Closure in v3.2.77

I have pulled down the reproduction issue to test, and as @ppmathis the issue is that the `APP_ENV` for your browser tests is set to `local` and not `testing`. If...

Issues with $arguments in visible closure on Filament\Actions\Action: Empty Arguments and Disabled Actions

Hey, it isn't possible for us to fix this, the code suggested above is correct. Filament does not know the arguments for the action until you pass them, and `$this->testVisibleAction->isVisible()`...

Panel::getUrl acts weird when authenticated

Hopefully fixed in v4 by #16624, let me know if there are additional issues