Add aria label to action th
Description
This pull requests, add aria-label="actions" to action th
Issue #14299
Visual changes
Before
After
Functional changes
- [x] Code style has been fixed by running the
composer cscommand. - [x] Changes have been tested to not break existing functionality.
- [x] Documentation is up-to-date.
the table header for that column lacks an accessible name, which is required for elements with the columnheader role.
This is not true. I agree that it's something that should be added, but it's not required. I would argue that the label should be more descriptive though. From an accessibility standpoint a user wouldn't know what to expect if there are just 'actions'.
Perhaps you can loop over all the defined actions in the table and make it look like:
aria-label="Edit, move or delete records"
Or if it's just one action:
aria-label="Edit records"
There could be many actions, especially if they are grouped, so I don't think listing them is what we should do here.
Also, this current PR is only suitable for English apps since the string is not translated
@danharrin that's true. Perhaps it's possible to count all specified actions to decide if the translation should be plural?
Sure, but it doesn't just need to adapt to the plural it also needs to be translated
@danharrin Fixed Plural and added localization. I will update other languages as well.
Thanks