Dan Gershony

Results 118 comments of Dan Gershony

Great work @DanGould we will verify all the findings when the node is stable.

If I am not mistaken checksum is actually not needed anymore @NicolasDorier mentioned something to me the other day.

We have `fundrawtransaction` on api not sure if we have it on RPC

I am quite sure this 2 methods are now implemented getnetworkinfo getblockchaininfo

Hi yeah, there is a todo in the code to bring over the logic from core https://github.com/stratisproject/StratisBitcoinFullNode/blob/master/Stratis.Bitcoin/BlockStore/BlockStoreBehavior.cs#L131 However the node implementation has either prone on/off, we didn't implement MIN_BLOCKS_TO_KEEP to...

To be considered when implementing this https://github.com/stratisproject/StratisBitcoinFullNode/issues/1461

It strikes me that as part of this task we should also review the rules in stratisX of how transactions are selected to be included in a block. This method...

>Remove in DBreeze is only a "logical" operation OMG ok yeah that defo could explain the bloating

Thanks @blane-nelson for the results. We don't do too many deletes on a normal node operations, we do delete on reorgs but those are quite rare so I would not...