StratisBitcoinFullNode icon indicating copy to clipboard operation
StratisBitcoinFullNode copied to clipboard

Published 20 hours ago • verified publisher icon stratisproject

Remove support for network messages without a checksum

Open noescape00 opened this issue 6 years ago • 2 comments

NetwokrPeerConnection.ReadMessageAsync allows messages without a checksum which was introduced at version 60002. Min protocol version is 70000, therefore there is no need to support that.

There are other code areas that check if checksum is there. They should be altered to always expect that.

noescape00 avatar Dec 24 '18 12:12 noescape00

If I am not mistaken checksum is actually not needed anymore @NicolasDorier mentioned something to me the other day.

dangershony avatar Feb 19 '19 12:02 dangershony

Yes, I removed it because it is quite useless while I needed to do some hacks to not allocate some byte arrays.

NicolasDorier avatar Feb 19 '19 12:02 NicolasDorier