StratisBitcoinFullNode icon indicating copy to clipboard operation
StratisBitcoinFullNode copied to clipboard

Review consensus rules

Open noescape00 opened this issue 7 years ago • 3 comments

noescape00 avatar Aug 02 '18 14:08 noescape00

this should be done after activation. removed sp1 label

noescape00 avatar Aug 16 '18 14:08 noescape00

Rules checked so far. An unchecked box means that there's a discrepancy between the reference implementation and Stratis.BitcoinD

  • [x] Magic #
  • [x] MinTxFee (1000)
  • [ ] FallbackFee is be disabled on core MainNet
  • [ ] MinRelayTxFee should be based on dust fee rate
  • [x] Genesis Details
  • [x] Buried Deployements
  • [ ] BIP 9 Softforks
  • [ ] Difficulty Adjustment interval set in seconds rather than blocks ChainedHeader.cs:434

My strategy thus far has been to follow my own advice from peeking at #1822 CVE:

" The most historically vulnerable attack surfaces are the Mempool and Transaction verification. [we should] compare present /bitcoin/bitcoin's implementations of these functions with SBFN's and closely match their logic to avoid exposure.

DanGould avatar Sep 10 '18 01:09 DanGould

It strikes me that as part of this task we should also review the rules in stratisX of how transactions are selected to be included in a block. This method https://github.com/stratisproject/stratisX/blob/master/src/miner.cpp#L102

dangershony avatar Oct 19 '18 11:10 dangershony