Review consensus rules
this should be done after activation. removed sp1 label
Rules checked so far. An unchecked box means that there's a discrepancy between the reference implementation and Stratis.BitcoinD
- [x] Magic #
- [x] MinTxFee (1000)
- [ ] FallbackFee is be disabled on core MainNet
- [ ] MinRelayTxFee should be based on dust fee rate
- [x] Genesis Details
- [x] Buried Deployements
- [ ] BIP 9 Softforks
- [ ] Difficulty Adjustment interval set in seconds rather than blocks
ChainedHeader.cs:434
My strategy thus far has been to follow my own advice from peeking at #1822 CVE:
" The most historically vulnerable attack surfaces are the Mempool and Transaction verification. [we should] compare present /bitcoin/bitcoin's implementations of these functions with SBFN's and closely match their logic to avoid exposure.
It strikes me that as part of this task we should also review the rules in stratisX of how transactions are selected to be included in a block. This method https://github.com/stratisproject/stratisX/blob/master/src/miner.cpp#L102