Dane Hillard

Results 121 comments of Dane Hillard

This will likely require updating the TypeScript configuration, because right now the `rootDir` is `packages/pharos/src/` but we're importing files that live in `.storybook/`.

[Pharos](https://github.com/ithaka/pharos) uses Lit to expose Web Components and I believe we're running into this as a limitation for the plugin working for us there. If y'all believe this plugin should...

Hey @justinfagnani, I think @brentswisher and I could work on getting a fresh PR together with a changelog. Do you think that will position you well for a new release?...

Consider a breaking change that affects the entire API, such as when we re-scoped the Pharos core package from `@pharos/core` to `@ithaka/pharos`. In one sense, every component was changed there;...

This has been added and is manually updated from time to time; we need to find a better way to automate this, ideally upon new releases.

This appears to be because of vitejs/vite#6179 and [how Rollup's dynamic imports work](https://github.com/rollup/plugins/tree/master/packages/dynamic-import-vars#options). The suggested workaround in the Vite issue discussion does improve the build, causing the transpiled code to...

Two workarounds(?) using `vite.config.js` courtesy of @michael-iden and @Ivanok: ```js import { defineConfig } from "vite"; import path from "path"; export default defineConfig({ resolve: { alias: { '/node_modules/styles/icons': path.resolve( __dirname,...

Huh, that's an interesting one. I note that this only appears to happen in the composed Storybooks (both the web component and the React flavor)β€”this does not happen in the...

Further, this happens on other components for other controls. I experience the same on Modal when attempting to change the `size` control. I'd say this is a general problem.