Dane Hillard

Results 130 comments of Dane Hillard

@gaby a reminder that despite having merge right I do not have release rights on this project.

This seems to be the case for several other icons, including: - `dash-small` - `checkmark-small` - `save` - `saved` - `star` - `star-filled`

@brentswisher Yeah I think we're open to that—the main thing @web/test-runner provides is a wrapper around Playwright to manage cross-browser testing, so as long as we're able to continue offering...

@satya-achanta-venkata I think focusing on the WC Storybook is probably a better use of time since the React stuff will go away (#856). I can see either spinning up the...

Chromatic recently added [automated a11y testing](https://www.chromatic.com/features/accessibility-test) to their pipeline, though it looks like it will be a paid feature. We're going to run with that for the moment, and see...

@lizlove can you clarify if we should be fixing the accessibility of the existing variant? I don't think we want to keep any inaccessible variants around!

Here is [a relevant passage from the Lit documentation](https://lit.dev/docs/components/defining/#typescript-typings) about providing good TypeScript typings as well.

@eslawski because React binds DOM properties, it's possible you don't actually need that conversion and can indeed use the camelCase flavor (I haven't tried this). I'd be interested if and...

@brentswisher Yeah, we've gone back and forth on this in similar situations in the past, for the fact that in some ways any visual change could be a breaking change...

@david-corneail can you confirm whether this is still reproducible? I'm having trouble getting it to do this presently.