lit-analyzer icon indicating copy to clipboard operation
lit-analyzer copied to clipboard

Published 20 hours ago • verified publisher icon runem

aria-haspopup no-incompatible-type-binding false alarm

Open joekukish opened this issue 3 years ago • 9 comments

Fixes #142

  • Updated underlying vscode-web-customdata that exposes the type for aria-haspopup.
  • Added test to make sure setting a non-boolean value is correct.

joekukish avatar Jun 09 '21 12:06 joekukish

@justinfagnani @43081j Any chance you can have a look at this?

joekukish avatar Jun 25 '21 11:06 joekukish

@joekukish LGTM, thanks! I had landed a change to the no-incompatible-type-binding test so there's a conflict. Can you merge or rebase?

justinfagnani avatar Aug 18 '21 18:08 justinfagnani

@justinfagnani I've rebased this branch and resolved conflicts. Please have a look!

joekukish avatar Feb 25 '22 15:02 joekukish

Thanks @joekukish !

One last thing - we need a changelog entry for this.

justinfagnani avatar Feb 25 '22 20:02 justinfagnani

👋 @joekukish @justinfagnani We just ran across this issue in making some updates to https://github.com/ithaka/pharos and I was wondering if there was any update here? Would be happy to pick up the mantle to get this fix in the next version if that would be helpful, but hate to take something over as it looks like it's just a missing changelog that needs to be added?

brentswisher avatar Aug 24 '23 14:08 brentswisher

@brentswisher sorry this one languished. Yeah, it's just missing a changelog. I think I couldn't commit to the PR branch so would have to make a new one. @joekukish if you can, great, or @brentswisher could take this. Thanks everyone!

justinfagnani avatar Aug 24 '23 14:08 justinfagnani

@justinfagnani I started looking into this, and found it appears to be working in the source code on the latest version of master.

I see the package is actively maintained with updates in the last few weeks/months, but a new release hasn't been cut since July of 2020. Am I misunderstanding something, it seems like there is a lot or work that has been done that isn't getting packaged up for consumers?

brentswisher avatar Oct 16 '23 21:10 brentswisher

Hey @justinfagnani, I think @brentswisher and I could work on getting a fresh PR together with a changelog. Do you think that will position you well for a new release? If there're other things outstanding we might be able to help as well; let us know.

daneah avatar Oct 17 '23 11:10 daneah

Release v2.0.1 looks to have landed a fix for this as well, this PR can likely be closed now.

brentswisher avatar Dec 05 '23 21:12 brentswisher