Dan Davison

Results 601 comments of Dan Davison

Hi @extrawurst, thanks! Delta isn't currently structured as a library for Cargo, but shall we sketch out what the minimal version of this could look like? The delta test suite...

`input` would be a string containing the stdout of a git diff command (`git diff`, `git show`, `git log -p`, `git stash show -p` etc) or `diff -u`. The return...

Incidentally, lazygit already uses delta, but as I understand it lazygit calls git as an external process whereas you are using libgit2. Is that right? So lazygit didn't need delta...

More precisely, I think the input might be three things: 1. A string containing git's diff output 2. A [`git2::Config`](https://docs.rs/git2/0.13.10/git2/struct.Config.html) struct representing the user's git config (which might have relevant...

@extrawurst What would a minimal API look like that would be useful for your purposes?

Hi all, thanks for the interest here. It should definitely be possible to refactor delta as a Rust crate exposing a function that can be passed a diff and will...

Thanks @th1000s -- I'd be very happy to keep up movement on here and get the librarification refactor in #902 in. Currently the use of `///` docs is very patchy...

Hi @Frederick888, thanks. What command are you typically issuing when you use delta to view `git format-patch` output? Do you have any thoughts about the right fix here? If we...

That sounds like potentially a good idea -- it feels a bit slack that we're not making use of the diff hunk line coordinates, and there might be other edge...

> (If you or anyone else would like to look into it, that would of course be very welcome.) We have [ARCHITECTURE.md](https://github.com/dandavison/delta/blob/master/ARCHITECTURE.md) as a starting point for anyone interested in...