Dan Davison

bytelines allows us to output lossy decoding. Before bytelines I was doing this, which meant an error message would appear in the middle of user's output: https://github.com/dandavison/delta/commit/9d1aafee2465b3b89de09ae72e1b8b8fbda4a981 We should look...

I have to say my instinct is that this doesn't feel like the right solution. But I don't think I have the problem clear in my mind so I'm sorry...

Thanks @plgruener. Do you have time to look at https://github.com/dandavison/delta/pull/664 and help me decide what the correct course of action is? In that PR, code was added that deliberately strips...

> This (=CR erases the line) does not happen with the default pager. Why does this happen with delta? I think this is because: Suppose we have a line ending...

Is it true that the problem is occurring because (1) git is placing an ANSI character between CR and LF: `CR ANSI LF` (2) bytelines is stripping the LF, leaving...

> Only when used with `-p` Thanks! > Therefore this issue is not related to the CR-ANSI-LF problem Right. OK, so: I think it is correct that delta's internal code...

Oh, I'm sorry @niklasbuechner, I let this one drop. Thanks very much for addressing this, I agree it's confusing.

Thanks for this @NightMachinary.

Hi @Yanpas, it does support unified diff format `diff -u` automatically. No-one has worked yet on adding support for `svn diff` output. A helpful starting point might be to post...

Thanks! I've made a start on this in https://github.com/dandavison/delta/pull/106. It looks very similar to unified diff output, so it should be a small change. (If you are able to compile...