Damien Ruscoe

Results 42 comments of Damien Ruscoe

Kodi devs, This is my first PR to this project so I would be appreciative if somebody could highlight anything which could be done better. Including from the coding standards...

> Sorry for the delay, don't have much Kodi time these days due to work. I'll try to bring in other reviewers. Reading the description, this seems like an appropriate...

> Do you happen to actually have any timings regarding the improvement? The main motivation for these changes is to improve the scan duration on lower-powered android boxes. I haven't...

Hi devs, Thanks for reviewing, I think this branch is at the stage of completed and is ready to be merged. What is the procedure to get this merged and...

> @damienruscoe: I still would like to see this merged, are you planing to finish this up? Hi Neo, yes. I want this in personally. Sorry for the delay, my...

> May i suggest to supply the Jenkins generated clang diffs, then to squash down everything to a single commit. Eases up review. 😉 Please can you verify that I...

> Now it is completely f*****d up. I know. I am currently screaming at git in my terminal.

> One more to fix and squash: > > ``` > git reset --hard 7cf714ec82efec8a6cd76745d0e42a24f5ab9776 > git rebase upstream/master > git reset upstream/master > git commit -a -m"[addons] Cache commonly...

> > Question: Is concurrent access to FilenameXMLCache possible? If yes better add a CCriticalSection. > > This question is still not answered. Long answer short... I am really not...

> There seems to be an overlap with the merged #26102, is the benefit still there? `GetScraperForPath` was the exact path I was targeting with this PR! The two approaches...