Damien Ruscoe comments

Results 42 comments of


                                            Damien Ruscoe

[CURL] Reduce the number of constructions of CURL objects.

@garbear I think this PR has stood up to scrutiny :) Are we good to merge? 👍

[CURL] Reduce the number of constructions of CURL objects.

> Merge time! Thanks for sticking with this, the PR came out really great. We value Kodi's performance on low-end hardware so every little bit helps. @garbear Ive worked in...

[CURL][tests] Added tests checking for differences between URIUtils::* and CURL::* methods.

Just to be explicit. I do not mind fixing these issues myself. I would like to find the correct behaviour first and verify my proposed changes won't subtly break something...

[CURL][tests] Added tests checking for differences between URIUtils::* and CURL::* methods.

Jenkins build this please

[CURL][tests] Added tests checking for differences between URIUtils::* and CURL::* methods.

> Sorry it's only been dead computer eyes on this PR so far, but codebase fixes and especially additional test cases are something we like, so this should get some...

[CURL][tests] Added tests checking for differences between URIUtils::* and CURL::* methods.

@garbear The scope of this PR had ballooned. I have disected the PR and shared the changes across multiple other PRs. Hopefully this is down to a bitesize change. I...

[CURL][tests] Added tests checking for differences between URIUtils::* and CURL::* methods.

@garbear This branch has been minimized with the excess work spread across other PRs. I think this is ready for a review. Thanks

[CURL][tests] Added tests checking for differences between URIUtils::* and CURL::* methods.

> Nice, this is much nicer to review. You have a good commit message too: Thanks. I agree. From the standpoint of a reviewer it was too much. I was...

[CURL][tests] Added tests checking for differences between URIUtils::* and CURL::* methods.

Jenkins build this please

[CURL] Refactored archive CURL parsing

This new Claude util is cool. Thumbs up! I liked that copilot made issues which could be marked as resolved, or at least reply to document errors. Is that possible...