Daira-Emma Hopwood

I think it's useful to be able to trivially obtain the ZIP 321 request because it is directly a field of the PCZT. Since that's how the proposal format works,...

@AndreaLanfranchi I used "`Co-authored-by: Andrea Lanfranchi `" to attribute you as a co-author for the last three commits. However I can't sign those with your gpg key, and you have...

Since this potentially affects peer-to-peer protocol compatibility (and involves parsing code and exceptions in C++), I'd like two reviews please :-) I suggest commit-by-commit review, with whitespace changes ignored for...

Incidentally, I also checked that `nVersion` and `nStartingHeight` were the only places in `ProcessMessage` where we deserialized into a platform-dependent type (`int` in both cases). We don't support platforms with...

@AndreaLanfranchi wrote: > I have no problems with either choice. In that case it can stay as-is.

With an important security caveat noted below, it's possible to use [CredentialManager.createCredential](https://developer.android.com/reference/kotlin/androidx/credentials/CredentialManager#createCredential(android.content.Context,androidx.credentials.CreateCredentialRequest)) to save the seed phrase as a username/password. (Worked example in [this video](https://www.youtube.com/watch?v=FULNucVxf94).) This will save the "password"...

Despite the [Block store](https://developer.android.com/identity/block-store) documentation saying it is end-to-end encrypted, I think this can only be with the user's device PIN/pattern/password, which is low-entropy and therefore almost useless. I updated...

I suggest reviewing with "Hide whitespace" initially. (One of the points of this is to avoid the tab slide to the right caused by nested error handling.)

I don't have a strong opinion, but [BIP 122 chain IDs](https://namespaces.chainagnostic.org/bip122/caip2) seem to have the right properties: they distinguish intended chain forks, but are stable across Network Upgrades that are...

In the ZIP Editors' meeting today, we identified that ZIP 236 is changing only section 3.4, when it should also be changing section 7.1.2, as ZIP 2001 does.