Daira-Emma Hopwood comments

Results 724 comments of


                                            Daira-Emma Hopwood

Report proposal errors earlier and more precisely where possible

~~This is not up-to-date with #1257. I will rebase it when that merges.~~ This is now rebased onto main.

Ensure symmetry of transparent output handling between `put_blocks`, `store_decrypted_tx` and `store_sent_tx`

Did merging #1402 fix this, or is there more to do?

Add support for `Value::one()` and `Value::zero()` and maybe, `Value::<F::From>::from()`

Yes we have quite a few instances of `Value::known` constructors for the constants 1 (7 cases), 0 (11 cases), and -1 (14 cases) in the Orchard circuit. We also have...

build(deps): bump EmbarkStudios/cargo-deny-action from 1 to 2

@dependabot rebase

build(deps): bump EmbarkStudios/cargo-deny-action from 1 to 2

@dependabot recreate

Meta-Proposal: Move all ZIP drafts into main branch

The only reason most of the current PRs haven't been accepted yet is lack of time on my part.

Make it possible to build with the "circuit" feature for `no_std` targets

This is harder than I thought, and will require releases of at least `pasta_curves` and the `halo2` crates (to avoid std dependencies via `rand_core`). Going to leave this on the...

Reduce MAX_INV_SZ so wtx invs fit within a network message

I don't understand the rationale. Why does this need to be changed, more precisely?

Reduce MAX_INV_SZ so wtx invs fit within a network message

> With the larger wtxid `inv` entries in ZIP-329, can `zcashd` send an `inv` message that is larger than the network message size limit? If it can, this isn't the...

Reduce MAX_INV_SZ so wtx invs fit within a network message

We had a close look at this. It appears as though it might technically be possible for zcashd to send a protocol message larger than the limit if there is...