Daira-Emma Hopwood comments

Results 724 comments of


                                            Daira-Emma Hopwood

Notation refactoring

> I couldn't figure out why the CRT implies that a group with composite order has proper subgroups. I'd be glad if anyone could give me a hint why this...

control-C stops zcashd more quickly during startup

Delayed until after 4.1.1.

Remove the incorrect const declarations in CTransaction.

@zkbot try

Remove the incorrect const declarations in CTransaction.

Consider doing it the way Bitcoin does (revamping how serialization works for transactions).

test LogPrint() format strings

We can statically count that the number of `%` characters in the format string matches the number of arguments: ``` #include #include #include "tinyformat.h" constexpr size_t CountChar(char c, const char*...

Implement UA-specific migrations for `zcash_client_sqlite`

Related to #369, which is the more general issue for non-UA-specific database migration.

Define a stable serialization format for `halo2::plonk::ProvingKey`

Because Halo 2 doesn't have a trusted setup (and the generators are computed by deterministically hashing to the curve), the only thing necessary to reproduce the proving key is the...

Add the packaging metadata to build the zcash snap

Concept ACK.

WIP: Delete old protocol version constants and simplify code that used them (corrected)

I need to rebase / check this.

Internal Security Review Results (of note-spending-v5 branch)

ZIP 307 should explicitly call out how to do the decryption in as side-channel-resistant a way as possible.