halo2
halo2 copied to clipboard
zcash
Notation refactoring
This PR closes #170.
I couldn't figure out why the CRT implies that a group with composite order has proper subgroups. I'd be glad if anyone could give me a hint why this holds. I looked into the cited material, but I didn't find such a claim there. To be clear, I'm not sure why this holds:
This group has composite order, and so by the Chinese remainder theorem it has proper subgroups.
I couldn't figure out why the CRT implies that a group with composite order has proper subgroups. I'd be glad if anyone could give me a hint why this holds. I looked into the cited material, but I didn't find such a claim there. To be clear, I'm not sure why this holds:
This group has composite order, and so by the Chinese remainder theorem it has proper subgroups.
https://crypto.stanford.edu/pbc/notes/group/cyclic.html
That's a direct proof that doesn't reference the Chinese Remainder Theorem. I guess it is more specifically the fundamental theorem of finite abelian groups that we're depending on, but that is very closely related to the CRT.
Hi @upbqdn. Thanks for the PR.
We currently have a contributor agreement for Halo2 and signing the agreement allows us to redistribute the code later under another license if we need to, without having to get your permission. This is similar to how contributor agreements work in Apache software projects as well. Just let me know what email address you like to use by emailing me at [email protected] and I’ll have the agreement sent over electronically via DocuSign for your signature.
