Daira-Emma Hopwood
Daira-Emma Hopwood
@ebfull wrote: > there isn’t a per-crate way to enable this. the top level crate defines this kind of stuff for everything being compiled
OK, so just librustzcash then. We should add a call in librustzcash that just panics, and have a gtest in zcashd that calls it and tests that the process aborts.
Here are the benchmark results for `cargo bench -- plonk-prover` in `halo2_proofs` after applying the [attached norandom.diff](https://github.com/zcash/halo2/files/9105735/norandom.diff.txt) (inspired by https://github.com/privacy-scaling-explorations/halo2/pull/73), which uses `Scalar::zero()` in various places instead of `Scalar::random(&mut rng)`:...
Most of the performance gap persists with this minimal diff, which only changes the sampling of r(X) and s(X) polynomials (as @sean and I suspected): ```diff commit 0569143ac8cc0cbfdf81ba6a0c6ecae7a233b2ea (HEAD ->...
Oh, I think it was disabled just because it is useful to preserve log information in order to diagnose errors reported by users, who usually won't have set `-debug`. We...
For mempool DoS limitation, isn't what we're evicting an equivalence set of possible transactions with the same effect? For v5 transactions, the mempool operates in terms of such equivalence sets...
@str4d, can this be closed? That is, are we confident that all cases where we should be using wtxids have been found?
Review needed for https://github.com/zcash-hackworks/zcash-test-vectors/pull/53; if that is okay then I'll file similar PRs for the other four MIT/Apache repos.
Needs 2 ACKs, since it affects key management.