Vadim Senderovich

Results 48 comments of Vadim Senderovich

@ppascualv This number is also parsed as valid in original libphonenumber. You can check it [here](https://rawgit.com/googlei18n/libphonenumber/master/javascript/i18n/phonenumbers/demo-compiled.html) and [open an issue for them](https://issuetracker.google.com/issues/new?component=192347&template=829703)

@mgibson8 It's hard to determine whether number is valid or not in case of Germany. Valid number can be from 5 to 15 digits after the country code. Such regex...

@mgibson8 there is now a ```Phonelib.strict_double_prefix_check``` that can help to overcome this issue. Anyway if you can share examples please.

@morgant thanks for reporting, the issue comes with ability of phonelib to ignore specified country in case it doesn't match the phone prefix. I just released 0.7.1 version introducing new...

@thomashexton I updated data of the gem, but it's still being parsed incorrectly. Check section [describing parsing issue](https://github.com/daddyz/phonelib#incorrect-parsing-or-validation). You can open issue for libphonenumber or just add additional regexes for...

@shqear93 nice PR, can you make this behavior optional, maybe via config param? And additionally this behavior doesn't respect possible param, this is required too

@yann120 do you have any way to provide country for phone validator? Or in case you are parsing french phones only you can define default_country for the gem.

@theblang Yes, I always advice to check [here](https://rawgit.com/googlei18n/libphonenumber/master/javascript/i18n/phonenumbers/demo-compiled.html). Check ```add_additional_regex``` documentation, it may help solving the issue. Or you can open an issue for libphonenumber [here](https://issuetracker.google.com/issues/new?component=192347&template=829703&pli=1)

@achowdhury7 I updated the data from google libphonenumber. Since the issue is marked as fixed, I guess the fix is also applied to my gem. Check version 0.6.35

Google are referencing [wikipedia](https://en.wikipedia.org/wiki/Telephone_numbers_in_the_Philippines) for PH prefixes, maybe you should try to update that page and add additional comment to your issue in google libphonenumber, since they wrote that can't...