phonelib icon indicating copy to clipboard operation
phonelib copied to clipboard

Missing prefixes for PH

Open achowdhury7 opened this issue 6 years ago • 3 comments

The following number formats are returned as invalid: +63 904-XXX-XXXX, +63 911-XXX-XXXX, +63 913-XXX-XXXX, +63 924-XXX-XXXX, +63 931-XXX-XXXX, +63 941-XXX-XXXX, +63 944-XXX-XXXX, +63 945-XXX-XXXX, +63 961-XXX-XXXX, +63 965-XXX-XXXX, +63 966-XXX-XXXX, +63 967-XXX-XXXX, +63 970-XXX-XXXX, +63 978-XXX-XXXX, +63 981-XXX-XXXX

An issue has been created on Google phonelibnumber's issuetracker for this: https://issuetracker.google.com/issues/134374016

achowdhury7 avatar Jun 04 '19 08:06 achowdhury7

@achowdhury7 I updated the data from google libphonenumber. Since the issue is marked as fixed, I guess the fix is also applied to my gem. Check version 0.6.35

daddyz avatar Jun 10 '19 04:06 daddyz

Hi @daddyz The following prefixes still don't work: 904, 913, 924, 941, 944, 970

Can you please help me with these? Thanks!

achowdhury7 avatar Jun 17 '19 10:06 achowdhury7

Google are referencing wikipedia for PH prefixes, maybe you should try to update that page and add additional comment to your issue in google libphonenumber, since they wrote that can't accept "not an official source" which is a bit strange. Just reference this updated page there

daddyz avatar Jun 27 '19 06:06 daddyz