Daniel Straub

Results 189 comments of Daniel Straub

The problem with conda might be due to > The most significant one is that Unicycler now enforces that SPAdes cannot be a version later than v3.13.0. This is because...

Sorry for the misleading idea. Assemblers and small test data are often problematic in my experience. Unfortunately I dont have a better idea how to solve that.

Thanks for the report and the additional details! Could it be related to the addition of radix sorting in https://github.com/nf-core/ampliseq/issues/706? If yes, we either have to use radix sorting everywhere...

DADA2 logs are merged [here](https://github.com/nf-core/ampliseq/blob/717abb8a0372c1821f5837ab3a902be90faf4cba/workflows/ampliseq.nf#L409-L414) by [dada2_stats.nf](https://github.com/nf-core/ampliseq/blob/2.9.0/modules/local/dada2_stats.nf). Furthermore, multiple sequencing runs are merged [here](https://github.com/nf-core/ampliseq/blob/717abb8a0372c1821f5837ab3a902be90faf4cba/workflows/ampliseq.nf#L418-L421) by [dada2_merge.nf](https://github.com/nf-core/ampliseq/blob/2.9.0/modules/local/dada2_merge.nf). Finally, `overall_summary.tsv` is produced [here](https://github.com/nf-core/ampliseq/blob/717abb8a0372c1821f5837ab3a902be90faf4cba/workflows/ampliseq.nf#L424-L430) by merging via sample names (see [merge_stats.nf](https://github.com/nf-core/ampliseq/blob/2.9.0/modules/local/merge_stats.nf)). I assume...

Also seems to appear with simple sample names such as sample1 sample10 sample2 sample20 definitively a sorting problem, will need to sort that out for the next release

> I don't think it makes much difference, but you shouldn't need to actually change anything in the case where the if clause is true because it's only one sample,...

I opened a PR correcting the issue in https://github.com/nf-core/ampliseq/pull/750. I thought that sorting all tables before merging might be even better than sorting just one, because it might prevent any...

Yes, joining on a key would be certainly best. But the file names (that determine row names in the tables) are very inconsistent at that point as mentioned in >...

Ok the fix in dev now, I hope it wont make any problem in the foreseeable future.

Any insight here @erikrikarddaniel ?